php-conventional-changelog icon indicating copy to clipboard operation
php-conventional-changelog copied to clipboard

Double slash after hostname in compare link

Open kyletaylored opened this issue 4 years ago • 6 comments

Seeing a double slash after the hostname in the version comparison link.

image

kyletaylored avatar Sep 21 '21 21:09 kyletaylored

I ran into the same, seems like {{owner}} isn't populated

Create a .changelog file with this

<?php

return [
  'commitUrlFormat' => '{{host}}/{{repository}}/commit/{{hash}}',
  'compareUrlFormat' => '{{host}}/{{repository}}/compare/{{previousTag}}...{{currentTag}}',
];

attiks avatar Oct 22 '21 12:10 attiks

Hi, to check it I need to know the repository URL format to check how the regular expression works when parsing.

marcocesarato avatar Oct 22 '21 12:10 marcocesarato

$ git remote show origin -n
* remote origin
  Fetch URL: [email protected]:UN-OCHA/iasc8.git
  Push  URL: [email protected]:UN-OCHA/iasc8.git

attiks avatar Oct 22 '21 12:10 attiks

Might be easier to clean the URL, replacing // with / in get....Url methods

attiks avatar Oct 22 '21 12:10 attiks

Strange that the owner is not populated. However I have released a new version with url clean and that improve the url format detection.

marcocesarato avatar Oct 22 '21 12:10 marcocesarato

:+1:

attiks avatar Oct 22 '21 13:10 attiks