Marco Castelluccio

Results 504 comments of Marco Castelluccio

The API for the failure summary would be https://treeherder.mozilla.org/api/project/mozilla-central/jobs/283993706/bug_suggestions/.

> @marco-c Do you want to assert the payload before hashing ? It's not exposed right now Do you mean in the test itself? Yeah it might make sense, so...

@La0 the warning mentioned in https://github.com/mozilla/code-review/issues/2665#issuecomment-3334296583 was not a full file one: ``` {"linter": "eslint", "path": "/builds/worker/checkouts/gecko/toolkit/actors/NetErrorParent.sys.mjs", "lineno": 17, "column": 10, "message": "> resource:///modules/GenAI.sys.mjs is part of Desktop Firefox and...

It looks like `check tree-sitter-mozcpp` took too long. We might need to increase its maximum runtime

Even with a maximum runtime of 3 hours, it's still running out of time. Have you tried running it locally? I wonder if there's a deadlock somewhere, or why it...

We could create a new OpusTrainer augmentation to add/remove periods

There is an augmentation like that here: https://langtest.org/docs/pages/tests/robustness#add-punctuation.

@evgenyrp does it make sense to also have a "AddEndPunct" modifier in addition to a "RemoveEndPunct" one? I see langtest has both "Add Punctuation" and "Strip Punctuation" modifiers (https://langtest.org/docs/pages/tests/robustness)

And it looks like they use all `['!', '?', ',', '.', '-', ':', ';']` and not just `.`

@alexle0nte are you going to work on this?