autowebcompat icon indicating copy to clipboard operation
autowebcompat copied to clipboard

Add tests for some functionality of the crawler

Open marco-c opened this issue 7 years ago • 4 comments

Maybe moving some crawler code in a separate module under the autowebcompat directory.

marco-c avatar Feb 20 '18 00:02 marco-c

I would like to work on this.

poush avatar Feb 20 '18 17:02 poush

I would like to work on this.

Sure, go ahead!

marco-c avatar Feb 20 '18 17:02 marco-c

@marco-c Need some help here. So on checking collect.py, I think read_sequence, get_all_attributes, screenshot, set_timeouts can be moved to autowebcompat directory and can be added in test cases. but get_all_attributes, set_timeouts and screenshot is driver module dependent which they receive as parameter. So is it right way of doing this or should I think and try again?

poush avatar Feb 20 '18 17:02 poush

For the functions that get a webdriver as parameter, you can create a webdriver in the test.

marco-c avatar Feb 20 '18 18:02 marco-c