autowebcompat icon indicating copy to clipboard operation
autowebcompat copied to clipboard

Limit size of full page screenshot

Open sagarvijaygupta opened this issue 6 years ago • 4 comments

Some webpages are extremely big. Some like quora or linkedin come with infinite scroll. We should keep a limit on it.

sagarvijaygupta avatar Jul 30 '18 06:07 sagarvijaygupta

Is there a way to detect infinite scroll in a website ? I think if you keep a limit on the screenshot there may be some sites which are just long pages but don't get the entire image because of the limit.

Another approach could be whitelisting sites ,like having a case that if the website is quora or LinkedIn or Facebook then the limit could kick in.

Shashi456 avatar Jul 30 '18 07:07 Shashi456

Infinite website is just a concern. Generally it starts loading when we reach very end (what I have noticed experimentally). So height provided is its initial height. Just wanted to make sure they don't create a problem.

sagarvijaygupta avatar Jul 30 '18 11:07 sagarvijaygupta

We can put a sane limit, it's OK if we don't get all possible images for a website.

marco-c avatar Jul 30 '18 13:07 marco-c

We actually want it: This happened now for Testing https://planet.mozilla.org/ (bug 10256) in firefox I got more than 4832 images (all white and blank)

sagarvijaygupta avatar Jul 31 '18 08:07 sagarvijaygupta