autowebcompat icon indicating copy to clipboard operation
autowebcompat copied to clipboard

Published 20 hours ago • verified publisher icon marco-c

[WIP] adding crawler functions to testing

Open poush opened this issue 7 years ago • 13 comments

Work in progress for #75

@marco-c Sorry for delay! I was busy in exams. So, till now what I have done is creating a class for setting up the selenium drivers and provided a sample use of it though one test case. I would like to know if this is good method or there are some changes can be made to make it better. If it looks good then other possible functions can be added easily.

poush avatar Mar 04 '18 19:03 poush

@marco-c Sorry for delay! I was busy in exams. So, till now what I have done is creating a class for setting up the selenium drivers and provided a sample use of it though one test case. I would like to know if this is good method or there are some changes can be made to make it better. If it looks good then other possible functions can be added easily.

Yes, the approach looks good to me overall!

marco-c avatar Mar 05 '18 11:03 marco-c

Codecov Report

Merging #103 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   18.95%   18.95%           
=======================================
  Files          16       16           
  Lines        1931     1931           
  Branches      328      328           
=======================================
  Hits          366      366           
  Misses       1562     1562           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96348a2...fc30dbe. Read the comment docs.

codecov-io avatar Mar 14 '18 12:03 codecov-io

@marco-c Also, can I break up the task of adding tests cases? So taking the changes done in PR as one part and rest is completed by creating issues or it should be better if it completes in one PR?

poush avatar Mar 14 '18 12:03 poush

@marco-c Also, can I break up the task of adding tests cases? So taking the changes done in PR as one part and rest is completed by creating issues or it should be better if it completes in one PR?

Sure, please file an issue for anything that should be tested that is not covered in this PR.

marco-c avatar Mar 14 '18 13:03 marco-c

@poush do you still intend to work on this?

marco-c avatar Mar 29 '18 10:03 marco-c

Closing for lack of response. Feel free to reopen if you still intend to work on this in the future.

marco-c avatar Apr 11 '18 09:04 marco-c

Please provide your feedback on this pull request here.

Privacy statement: We don't store any personal information such as your email address or name. We ask for GitHub authentication as an anonymous identifier to account for duplicate feedback entries and to see people specific preferences.

propr[bot] avatar Apr 11 '18 09:04 propr[bot]

@marco-c can you please reopen it? I would like to continue on it.

poush avatar May 19 '18 21:05 poush

Sure!

marco-c avatar May 20 '18 15:05 marco-c

ping @poush

marco-c avatar Jul 16 '18 14:07 marco-c

😅Got busy in my summer project. Give me a week or two. I will fix the travis issues.

poush avatar Jul 28 '18 14:07 poush

@marco-c test seems passing, please have a look. I will put into the issue what next methods will be covered in next PR.

poush avatar Aug 30 '18 08:08 poush

@marco-c Can you please check it again? I fixed all the reviews that same day.

poush avatar Oct 08 '18 15:10 poush