Marc Khouzam

Should `tanzu init` be deprecated?

1

**Bug description** When the `global.context-aware-cli-for-plugins` feature is enabled, which is now the default, `tanzu init` does the same thing as `tanzu plugin sync` (except for an update of the catalogue...

tanzu-framework/cli/runtime module is not getting released

2

**Bug description** The new `github.com/vmware-tanzu/tanzu-framework/cli/runtime` sub-module needs to be consumed by plugins outside of tanzu-framework. However, sub-modules in tanzu-framework are not being released according to Go import rules and therefore...

Do not commit: Support fish shell completion

2

Completion tests adaptation for https://github.com/helm/helm/pull/7690 Should only be merged once the helm PR is merged.

The installation of some tools has hard-code paths in them. For example: ``` $ head -1 .acceptance/.venv/bin/robot #!/Users/marckhouzam/git/acceptance-testing/.acceptance/.venv/bin/python3.7 ``` If I want to move the acceptance-testing repo to a new...

It is possible for a user to run make from outside of the acceptance-testing directory. For example $ cd /tmp $ make -f $GOPATH/src/helm.sh/acceptance-testing/Makefile To support this, the Makefile must...

Var ROBOT_DEBUG_COMPLETION to allow completion tests to print to console

2

ROBOT only gives the tester access to the logs at the very end of the test run. When developping, this can be annoying. This change, admittedly a hack, allows to...

Remove support for Helm v2

1

With Helm v2 having reached EOL, I was wondering if we should remove v2 support from the acceptance-tests. The idea is simply to simplify the maintenance of the acceptance-tests. Any...

CI tests failing in setup phase

2

The CI tests have started to to fail during the setup phase with the following error. Refs: https://github.com/helm/acceptance-testing/pull/77 https://github.com/helm/acceptance-testing/pull/78 ``` which virtualenv + true + pip3 install --user virtualenv Collecting...

Pass arguments to the help function

6

Fixes #2154 This PR makes sure that when Cobra calls `HelpFunc()(cmd, args)`, the proper arguments are passed to the function. With this, when the help function is overridden, the new...

I can override the help function using: - `cmd.SetHelpFunc(func(c *cobra.Command, args []string))`. Notice that the new help function I will define takes a command and its arguments as parameters, just...