Marc Khouzam

Results 311 comments of Marc Khouzam

Hmm... Editing online seems to have done a commit that doesn't pass the CLA check. I'll have to clean that up once I'm at a full computer.

This makes sense. I'm surprised it wasn't fixed earlier 😄 . Thanks for the PR! In fact I think the same problem applies to "deprecated" commands. I think that instead...

> I think [IsAvailableCommand()](https://github.com/spf13/cobra/blob/f848943afd7212766aadc19256cf9e7384980281/command.go#L1385) only works when the command has subcommands or has a run function. I think it is possible to have doc only commands which do not have...

@aliscott As pointed out by @Luap99, we should consider the case of `AdditionalHelpTopic`, so I think we should check that the command is neither hidden nor deprecated explicitly instead of...

> Also see the linked issue in the function comment: [#393 (comment)](https://github.com/spf13/cobra/issues/393#issuecomment-282741924) Brilliant! I had not noticed the link in the comment 🤦‍♂️

@jpmcb This is ready for a second review.

> This looks good to me - but I'm a _bit_ confused as to the root cause of this. _Why_ are commands that are deprecated or hidden getting different paddings?...

> This seems like a better approach to me as well. People do tend to code/script around these sorts of things so I'm slightly curious if it would be a...

Thanks @JaySon-Huang! I can reproduce the problem. I haven't looked at the fix yet, but we will need to be very careful not to break anything.

Thank you for the suggestion @linuxboytoo. Could you add a description of what the PR aims to provide and instructions on how it can be tested? You will also need...