Marc Khouzam

Results 311 comments of Marc Khouzam

This problem was reported in `kubectl` where they shadow persistent flags (probably by mistake): https://github.com/kubernetes/kubernetes/issues/103769 I've traced the problem to https://github.com/spf13/cobra/blob/master/command.go#L1502-L1506 where we determine the list of local flags for...

This looks great @jpmcb, thanks for writing this up! I will take a bit of getting used to 😄 but I think it will be worth it.

Hi @ekamwctx. There is no special support for upgrading within Cobra. However you can implement an `upgrade` command yourself and do whatever you need within it. But I expect others...

Hi @shanduur-auto. Currently there is no special support from Cobra for what you are asking. You would have to do the verification yourself in your program.

Nice catch! Thanks @scop. I'll run some tests on this next week and get it merged. I assume this was the only unbound variable problem with ActiveHelp?

I believe the test failures are because of the `2020` years that need to be updated, see #1309

I forgot about this one. I will rework it.

> An observation is that as the `completion` command is hidden, no completions are generated for its arguments (i.e. "foo completion Tab") Nice attention to detail! The completions should work...

While working on this I ran into another completion bug for programs that don't have sub-commands. I've opened issue #1562 and posted a fix in #1563. I'm still looking at...