Marc Khouzam

Results 311 comments of Marc Khouzam

Hi @rdgoite. I hope I understood your question properly. Notice that the check for nil is made against `c.Args` which are not the actual arguments but the function the program...

> Thanks @marckhouzam. So to clarify, `Args` is a `PositionalArgs` which is a function for validating arguments. If that's not set, it means then there's no need to check the...

> Should `kubectl -n` and `kubectl -itn` complete to all available namespaces or complete to flag `-n`? To all available namespaces

> > Should `kubectl -n` and `kubectl -itn` complete to all available namespaces or complete to flag `-n`? > > To all available namespaces Actually, probably not. Currently if we...

I put the lifecycle/frozen label on this one.

@scop, you may have some expertise on this. Do you have special handling if a completion has a space in it for bash?

> Should the `.idea/` reference also be removed from `.gitignore`? There is no official agreement to not put those things in the `.gitignore` for this project, but I at least...

@jpmcb This PR fixes the fact that the `--version` flag was not output by the `help` command. I don't think that changing help output is a backwards-compatible issue, so I...

> Nice! Just a quick touch up: > > * Can you squash your commits and write a single commit message that covers this? (if not, I'd be happy to...