servicebus_exporter icon indicating copy to clipboard operation
servicebus_exporter copied to clipboard

Published 20 hours ago • verified publisher icon marcinbudny

Updated to new Azure ServiceBus Go SDK

Open andersosthus opened this issue 4 years ago • 2 comments

Changes:

  • Updated to use https://github.com/Azure/azure-sdk-for-go
  • Replaced logrus with klog/v2
  • Made parts of the fetching more parallel
  • Built with Go 1.17

Only thing is the new TotalMessages field on Topic Subscriptions. We could potentially put that in the existing ScheduledMessages field there, not sure about that one.

andersosthus avatar Nov 25 '21 12:11 andersosthus

Hi Anders, thank you for the contribution. Unfortunately I won't be able to take a look at this for next ~1,5 weeks. I'll try to come back to this ASAP.

marcinbudny avatar Nov 25 '21 13:11 marcinbudny

No worries, I realized after I'd done the upgrade that I needed some custom logic in the exporter, so I wrote a new one for my specific use case. But I'll still follow up on this one if there are anything you would like me to change/fix for the PR.

andersosthus avatar Nov 25 '21 15:11 andersosthus