libjwt-typed icon indicating copy to clipboard operation
libjwt-typed copied to clipboard

Bounds too restrictive (for Nix)

Open someodd opened this issue 2 years ago • 4 comments

This library has been a joy to use, I really like it--good work.

I noticed something when attempting to use Nix for my project. libjwt-typed is marked as broken. I was able to progress far enough to realize some simple fixes (mark libjwt as system dependency was one), but the one I'm writing you about is the version bounds for base in your project. In my project I use base 4.14.3.0 and everything plays nice. However, Nix seems to only provide base 4.16.3.0, but the bounds of libjwt-typed for base seems to be >=4.13.0.0 && <4.15.

Is there anyway to change the bounds to be more flexible? I may even test out 4.16.3.0 specifically with libjwt-typed (and subsequently make a PR) once I resolve something locally. Thank you.

someodd avatar Aug 07 '22 06:08 someodd

Thank you very much! Nice to hear it. I have to admit I was neglecting this library a bit and was not keeping up with the dependencies marching forward (I believe that it's got kicked out of Stackage). That said, I am actually working on a rewrite to get things tidied up and bring it up to date. I've also not been too happy with libjwt (C dependency) and I will probably get rid of it and just use GnuTLS + JSMN directly. But this re-work has been going very slow, so there is no point in waiting for it to happen. If you are willing to test it, I will gladly change the bounds and make a new revision on Hackage. In case something in the code needs to be changed, we'll simply make a new release. Thank you very much!

marcin-rzeznicki avatar Aug 07 '22 13:08 marcin-rzeznicki

I got things to work by simply by making a cabal.project:

packages: *.cabal

allow-newer:
  libjwt-typed:base,
  libjwt-typed:text

... instead of using --allower-newer, which would present an issue with a later version MonadTime removing an instance that libjwt-typed uses.

Would you like me to make a PR to increase the bounds for text and base?

someodd avatar Aug 10 '22 00:08 someodd

Sure! Thank you very very much!

marcin-rzeznicki avatar Aug 11 '22 20:08 marcin-rzeznicki

@marcin-rzeznicki done! You may want to run tests on it, because I have not. Please see commit notes.

https://github.com/marcin-rzeznicki/libjwt-typed/pull/3

someodd avatar Aug 12 '22 01:08 someodd