Marc Hermans

Results 198 comments of Marc Hermans

Note due to changes needed in signatures of objects this will likely target 1.20. In short: https://github.com/MinecraftForge/MinecraftForge/blob/bb4818630c0c6cdd7c4178b4d77dc406153c2bcb/fmlloader/src/main/java/net/minecraftforge/fml/loading/moddiscovery/AbstractModProvider.java#L86 needs to become a parameterized version either pulled up into createMod() or some...

> > After further testing I have succeed in making minecraft to be aware of kotlin language provider ![image](https://user-images.githubusercontent.com/41675181/179453480-f09708d5-3c5e-47da-bfcb-a78f3761d019.png) [kff_testing_kit.zip](https://github.com/MinecraftForge/MinecraftForge/files/9129733/kff_testing_kit.zip) > > But it's still unable to access kotlin libs...

Okay, so bare with me, this took a very deep dive into DFU to understand why this happens. So let me clarify some points: _Let's start with some terminology:_ -...

So this is not a good idea. We simply can't use tags for logic which runs on the server like this. This is because the vanilla client still needs to...

> I don't think this is an issue, as they are only used on the server, not the client. This would not result in a desync. That is exactly the...

Because capabilities are not designed for it and they are not supposed to be Client only. But i can ask internally if we might want to add support for it.

> > Instead of attaching it to an item (so making a field for the handler on the item itself) make a central manager which holds a map from Item...

This looks good, code wise. Performance wise it is not an issue to fire the events. I still need to run the tests though, but I likely won't have time...