Marc Hermans

Results 144 comments of Marc Hermans

When I designed the default value caching, I also looked into this. As of now we don't consider this a bug. The default value supplier should return a new instance...

> > The default value supplier should return a new instance every time it is invoked. > > which is exactly the bug here, supplier is called _once_ and it's...

I am not entirely sure how modifying the firing order would fix your issue. Especially since anybody can open another screen in the Closed event which would prevent the HUD...

That is an understandable thing to want to know, but I I would just like to point out that your closing event reorder does not solve the problem. I can...

> Then the author is to blame for not using the correct forge events that are to be used in this situation and they should be pointed to the correct...

Interesting thanks for the report, I will try to fix this asap.

I am checking this now I think this might be related to us just injecting all deps as game libraries if they are not FML aware.

I tracked the issue down to the kotlin libs and wing unaware of fmls systems and as such being injected into the game layer and not the plugin/service layers