sharik icon indicating copy to clipboard operation
sharik copied to clipboard

Change Permissions Settings ⚠️

Open dhishkyaon opened this issue 4 years ago • 8 comments

The app requires permission to manage 'All Files'. Instead of this the app should allow user to select file from file picker. I don't know exactly which term to use 😂 but i think you can get my point. Managing all files is not good for security imo.

dhishkyaon avatar Aug 15 '21 09:08 dhishkyaon

100th issue!!! :fireworks: :champagne:

Thanks! That's actually a very good idea, I don't actually think we need to be able to access all files, since they are cached in app's storage anyways. I'm going to research this a bit more though.

Thanks again :)

marchellodev avatar Aug 15 '21 11:08 marchellodev

It seems like this permission is necessary for the app to be able to share files. See this

marchellodev avatar Aug 20 '21 13:08 marchellodev

This app can send and receive files without that permissions.

dhishkyaon avatar Aug 20 '21 13:08 dhishkyaon

@hellyeahmfs I have only one android device near me, are there any other apps that do that?

marchellodev avatar Aug 21 '21 11:08 marchellodev

Also, I have just noticed that the minimal verison of android that Snapdrop supports is 5 ( minSdkVersion 21). However, we target android 4 as well. So, as far as I understand, this permission is necessary for the app to function on android 4. Please see the link I provided earlier.

marchellodev avatar Aug 21 '21 12:08 marchellodev

Okay. But i think supporting Android 4 is not very much important because most of the people don't use that (and imo people don't use Android 5 too 😂)

This feature is going to increase security and privacy very much and thats a very good sign for an app.

If you want to still support Android 4 and don't want to implemant it for now thats your choice :-)

dhishkyaon avatar Aug 21 '21 13:08 dhishkyaon

Share via HTTP app works just like Sharik without these permissions.

dhishkyaon avatar Aug 21 '21 13:08 dhishkyaon

Share via HTTP app works just like Sharik without these permissions.

Yeah, it also seems to support android 4 ('minSdkVersion 14'), I'll take a look at it a bit later.

Thanks!

marchellodev avatar Aug 21 '21 14:08 marchellodev