react-virtualized-sticky-tree icon indicating copy to clipboard operation
react-virtualized-sticky-tree copied to clipboard
verified publisher icon marchaos

prop scrollTop is not working? onScroll event cause a bug. Gif proof

Open JumpAttacker opened this issue 5 years ago • 4 comments

Hey, seems code do noting with props.scrollTop

also if onScroll event is not undefined (and i change state in this handle), its put in dom all elements above

https://gfycat.com/BrokenInsignificantChinchilla

upd seems its UNSAFE_componentWillReceiveProps doing that

JumpAttacker avatar Sep 08 '20 08:09 JumpAttacker

I believe this is fixed in 3.0.0 - I can probably back port the fix to 2.x

marchaos avatar Dec 01 '20 09:12 marchaos

@marchaos you mentioned 3.0.0, are you planning on releasing it ? I noticed current version is still 2.x

laurelgr avatar Mar 10 '22 01:03 laurelgr

After looking a bit, in fact latest npm version is 3.0.0-beta13, which seems to be typescript branch (and pending PR) if I am not mistaken. A bit confusing, especially with the example still being from 2.x and not compatible anymore

laurelgr avatar Mar 10 '22 09:03 laurelgr

Maybe either update the README to use the 2.1.30 version from npm, or put latest tag to 2.1.30 version instead, and beta tag to 3.0.0-beta13 ? Changing the tags would avoid people downloading a version with wrong README

laurelgr avatar Mar 10 '22 09:03 laurelgr