lesscss-maven-plugin
lesscss-maven-plugin copied to clipboard
marceloverdijk
Contributors wanted
Hi. It looks like nobody has free time for this project. The current snapshot is broken after several merged pull requests. Plase talk to the project owner (Marcel) if you want to become a comitter. Thank you
Hi @cpopov,
I'm offering to release a new version of the lesscss-maven-plugin to Maven Central. My personal motivation is that I want to be able to use the less compiler in watch mode for Bootstrap 3.1 in my JCRBrowser project. I would depend on the latest lesscss-java 1.6.1 as soon as it's available, go through the pull requests, see if I personally would merge them and comment in the pull requests if needed. Then I create a release vote that lists all the pull requests I would merge. If no veto is cast I release the new plugin to Maven Central. Please tell me if you want me to release a new version.
Cheers,
Sandro
Hi @marceloverdijk,
if you would like to, I would create a release here as well. I will change the approach a bit. I will update my fork of lesscss-maven-plugin with the pull requests that I can use. Then I will see if there are any merge conflicts, see if the test are running and I will try practically if it is working for my project. After that I will ask if there are any vetos. If not I will create the release commits in my fork and send a pull request back to this project. After it is merged I can start releasing it to Maven Central. What do you think?
Best,
Sandro
How do you want to handle the versioning? As I understand it, you prefix the plugin version with the less version and add the version of the plugin within the less version with one number. This means you don't distinguish between major, minor and bugfix versions. That doesn't allow you to show breaking changes in the plugin. I suggest to use 1.6.1.1.0 as the next version of the plugin. What do you think?
Hi @marceloverdijk,
do you want me to do the release here as well? I could successfully merge the following pull requests into my fork https://github.com/sandroboehme/lesscss-maven-plugin of the plugin: #12 #36 #25 #17 #16 #7 In this fork I set the dependency to https://github.com/marceloverdijk/lesscss-java/pull/42 which uses Less 1.6.1. But my artifact versions don't reflect the Less 1.6.1 version yet as I would first like to clarify with you how to set the correct version name. In this merges I fixed the merge conflicts and test cases if needed. This means all tests are working. I also used this plugin to successfully compile my Bootstrap 3.1 project.
The only bug I see is, that the new lesscss-java dependency leads to a new line at the end of the generated css files. But I would release it anyways and create an issue for that. In a few days I will check again if some discussions in the pull requests make it possible to merge more pull requests. After that I will send a pull request with my fork containing the final code with all the other pull requests. This one should be trivial to merge and then I can create the release at Maven Central.
Best,
Sandro
Hi @marceloverdijk, hi @cpopov,
it sadly doesn't work with a pull request as described here: https://github.com/marceloverdijk/lesscss-java/issues/41#issuecomment-38322824 Please tell me if you want me to create a release.
Best,
Sandro
Hi. Marcel can give you commit rights. I also moved on, no time for this project. I also prefer using node.js for less. it is much faster than Rhino. Maybe we should make a maven plugin that delegates to node to compile less.
Regards
On Fri, Mar 21, 2014 at 9:01 PM, Sandro Böhme [email protected]:
Hi @marceloverdijk https://github.com/marceloverdijk, hi @cpopovhttps://github.com/cpopov ,
it sadly doesn't work with a pull request as described here: marceloverdijk/lesscss-java#41 (comment)https://github.com/marceloverdijk/lesscss-java/issues/41#issuecomment-38322824 Please tell me if you want me to create a release.
Best,
Sandro
Reply to this email directly or view it on GitHubhttps://github.com/marceloverdijk/lesscss-maven-plugin/issues/39#issuecomment-38323701 .
This sounds like a very good idea. I don't really know how to do that. But what would be needed to delegate to node.js?
I see a lot of activity lately which is good.However I don't have the time to follow up to questions etc.
Would it be a good to transfer this repo to an organization managed by someone else than me. Maybe to https://github.com/less @cloudhead?
Any ideas are welcome to move less-java and less-maven-plugin move forward!
I'm happy to repackage my fork of this plugin if someone is willing to pull and release it. See #44.