lesscss-maven-plugin icon indicating copy to clipboard operation
lesscss-maven-plugin copied to clipboard

Mark lesscss-maven-plugin as @threadSafe?

Open chludwig-haufe opened this issue 11 years ago • 2 comments

Hi,

I typically build our project with the Maven option "-T 1.5C"; this reduces the build time (on my hardware) significantly. However, since we added the lesscss-maven-plugin to our build, I get a warning:

[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that are not marked as       *
[WARNING] * @threadSafe to support parallel building.                     *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in cae-base-webapp:
[WARNING] org.lesscss:lesscss-maven-plugin:1.3.3
[WARNING] *****************************************************************

According to https://github.com/marceloverdijk/lesscss-java, lesscss-java itself is thread-safe. So is there any inherent reason why you cannot mark lesscss-maven-plugin as @threadSafe? Or can you please do so?

Thanks!

Regards, Christoph

chludwig-haufe avatar Nov 14 '13 17:11 chludwig-haufe

I would like to know this also.

Rincewind77 avatar May 09 '14 08:05 Rincewind77

I analyzed the code and I think it is thread safe. The plugin uses Rhino, which creates new JavaScript environment for every thread.

I wrote my own (https://github.com/gabrysbiz/lesscss-maven-plugin) which also uses Rhino library. I makred it as thread safe.

Ps. Marcel sorry for advertising my plugin on your site, but this plugin is not developed for a long time.

agabrys avatar Jun 28 '15 16:06 agabrys