cx_Freeze icon indicating copy to clipboard operation
cx_Freeze copied to clipboard

Potentially incorrect filename for MSI file

Open cainesi opened this issue 2 years ago • 2 comments

Describe the bug When the name of the msi file is specified by passing the target-name parameter to the bdist_msi command, the msi is created with the wrong file name.

To Reproduce In the "simple" sample, execute bdist_msi with --target-name a.msi.

An msi file is created named "a.msi-0.1-win64.msi".

Expected behavior Create an msi file named "a.msi". That has historically been the behavior.

Desktop (please complete the following information): Python 3.9 / Cx_freeze 6.11.1 / Windows 10

Additional context I suspect this may have been an unintended change made when the msi module was integrated into cx_freeze?

A "quick and dirty" fix is proposed in PR #1591.

cainesi avatar Aug 20 '22 19:08 cainesi

While fixing issue #1510 (fixed in PR #1520), I detected an issue and the fix (PR #1524) probably is incomplete.

marcelotduarte avatar Aug 20 '22 19:08 marcelotduarte

Hi @marcelotduarte, it looks like you are correct that the changes in #1524 were the source of the issue. Is there an easy way to explain what the intended change in #1524? That would help me understand what fix might be appropriate.

cainesi avatar Aug 21 '22 03:08 cainesi

cx_Freeze 6.13.0 has just been released.

marcelotduarte avatar Oct 26 '22 03:10 marcelotduarte