rethinkdb icon indicating copy to clipboard operation
rethinkdb copied to clipboard

Package migration to null safety.

Open brunoalfred opened this issue 3 years ago • 3 comments

brunoalfred avatar Sep 13 '21 18:09 brunoalfred

Hi Bruno! That's an excellent contribution! I will check everything until Wednesday. Thanks!

marceloneppel avatar Sep 14 '21 00:09 marceloneppel

Hi Bruno! That's an excellent contribution! I will check everything until Wednesday. Thanks!

Please review my PR.

brunoalfred avatar Sep 19 '21 15:09 brunoalfred

Hi @brunoalfred! Sorry for the delay. I will review your PR until tomorrow. I saw some errors in the master code with the CI and I'm checking a way to fix them. Did you run the dart test command? I tried locally in your branch and got some errors like the one below (I will check again tomorrow):

00:02 +0 -13: loading test/aggregation_test.dart [E]                                                                                         
  Failed to load "test/aggregation_test.dart":
  lib/src/ast.dart:28:26: Error: The argument type 'Map<dynamic, dynamic>' can't be assigned to the parameter type 'List<dynamic>'.
   - 'Map' is from 'dart:core'.
   - 'List' is from 'dart:core'.
      invocationParams.add(options);
                           ^
  lib/src/net.dart:24:15: Error: The argument type 'Map<dynamic, dynamic>' can't be assigned to the parameter type 'int'.
   - 'Map' is from 'dart:core'.
        res.add(optargs);
                ^

I'm fixing the CI to test there and avoid some problems related to my machine.

marceloneppel avatar Sep 20 '21 03:09 marceloneppel