PAMI icon indicating copy to clipboard operation
PAMI copied to clipboard

Published 20 hours ago • verified publisher icon marcelog

added bridgelist action, event and tests for it

Open wizzle opened this issue 7 years ago • 6 comments

wizzle avatar Jan 17 '18 11:01 wizzle

Coverage Status

Coverage decreased (-0.05%) to 92.192% when pulling ab9a413578ae966b14ecb33fdec82450e1e981a6 on wizzle:master into f586d0fcbf7db7952965ccb91e4ed231bd168fb3 on marcelog:master.

coveralls avatar Jan 17 '18 11:01 coveralls

Coverage Status

Coverage decreased (-0.05%) to 92.192% when pulling 85d51e1bfcf442316fd8b840e156d8b1691e168a on wizzle:master into f586d0fcbf7db7952965ccb91e4ed231bd168fb3 on marcelog:master.

coveralls avatar Jan 19 '18 12:01 coveralls

Coverage Status

Coverage decreased (-0.05%) to 92.192% when pulling 4fc5bb3c37e60fc46e9c7d4b60d33d3696ac93b5 on wizzle:master into f586d0fcbf7db7952965ccb91e4ed231bd168fb3 on marcelog:master.

coveralls avatar Jan 19 '18 12:01 coveralls

Coverage Status

Coverage increased (+5.8%) to 98.07% when pulling fc2d8ef2827ed2ab75d912cd1a146b70fce20d85 on wizzle:master into f586d0fcbf7db7952965ccb91e4ed231bd168fb3 on marcelog:master.

coveralls avatar Jan 19 '18 14:01 coveralls

Thanks for the contribution! :) A small comment before accepting: I see there are some changes that don't look related (docblock updates, vars/args names), these might be fine but make this pr unnecessary big. Please open separate PRs for those so we can track the changes better.

marcelog avatar Jan 20 '18 23:01 marcelog

Sorry, but I have no idea how I could split this PR to the few PR.

Those changes were made for phing builder because some variable names in phpdoc block differed from those which was used in methods.

wizzle avatar Jan 22 '18 07:01 wizzle