angular-drag-and-drop-lists icon indicating copy to clipboard operation
angular-drag-and-drop-lists copied to clipboard

do not start drag if dnd-nodrag && no dnd-handle

Open adrum opened this issue 7 years ago • 4 comments

Fixes #404

adrum avatar Jul 05 '17 20:07 adrum

I have a small question: what's the difference by returning true/false on dragstart event?

line 98 if (element.attr('draggable') == 'false') return true; returns true; while your patch if (element.attr('dnd-nodrag') !== undefined && !event._dndHandle) return false; returns false

benxshen avatar Jul 17 '17 05:07 benxshen

I think my instincts told me to return false if the drag did not succeed. I'm not entirely sure what the difference is or what the return value is used for. I can change it to true if that's the correct value to return.

adrum avatar Jul 17 '17 09:07 adrum

Anyone knows good alternative? This entire tool looks dismantled and overall broken/

What's with pull request?

sneakyfildy avatar Oct 03 '17 09:10 sneakyfildy

Great fix. This really needs to be merged into the main branch. It fixed an issue I had where clicking on a drag handle quickly a couple times would cause a couple classes to remain on the element like dndDraggingSource after the click was complete.

PaulDMendoza avatar Apr 12 '18 18:04 PaulDMendoza