angular-drag-and-drop-lists
angular-drag-and-drop-lists copied to clipboard
marceljuenemann
Added commonjs support
I'm not really familiar with CommonJS, is that compatible with RequireJS?! What is the impact of this PR on users that don't use CommonJS? Are all users that use the main attribute of the package.json using CommonJS?
I think this PR looks good to me though, unlike #301 it doesn't add anything for users that don't use CommonJS.
The index.js file will make the angular module into a CommonJS module, and exports the name of that angular module. This makes it possible to import in nodejs/webpack/es6 and so on. For users that don't use CommonJS, the angular-drag-and-drop-lists.js is unchanged, so it will not make a difference.
Other modules use the same way to support CommonJS, for example: https://github.com/danialfarid/ng-file-upload/blob/master/index.js https://github.com/angular-ui/bootstrap/blob/master/index.js
On Tue, Jan 17, 2017 at 12:51 AM, Marcel Juenemann <[email protected]
wrote:
I'm not really familiar with CommonJS, is that compatible with RequireJS?! What is the impact of this PR on users that don't use CommonJS? Are all users that use the main attribute of the package.json using CommonJS?
I think this PR looks good to me though, unlike #301 https://github.com/marceljuenemann/angular-drag-and-drop-lists/pull/301 it doesn't add anything for users that don't use CommonJS.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/marceljuenemann/angular-drag-and-drop-lists/pull/350#issuecomment-272987624, or mute the thread https://github.com/notifications/unsubscribe-auth/ARep5Ldir_LF4SfwP755B7DSDmsWiFaJks5rTAJogaJpZM4KsZy8 .
