ML_SynthTools icon indicating copy to clipboard operation
ML_SynthTools copied to clipboard

to trully fix ESP32S3 I2S interface...

Open matixan opened this issue 1 year ago • 2 comments

Here are some not usual #ifdef https://github.com/marcel-licence/ML_SynthTools/blob/3b8cf78d514c704e08a32ad8390be5deb5457ff1/src/i2s_interface.h#L505-L507 change these to

#ifdef ARDUINO_RUNNING_CORE
#ifndef CONFIG_IDF_TARGET_ESP32S3
    .mck_io_num = I2S_PIN_NO_CHANGE,
#else
    .mck_io_num = I2S_MCLK_PIN,
#endif
#endif

Also https://github.com/marcel-licence/ML_SynthTools/blob/3b8cf78d514c704e08a32ad8390be5deb5457ff1/src/i2s_interface.h#L531-L536

	#ifndef CONFIG_IDF_TARGET_ESP32S3
    REG_WRITE(PIN_CTRL, 0xFFFFFFF0);
    PIN_FUNC_SELECT(PERIPHS_IO_MUX_GPIO0_U, FUNC_GPIO0_CLK_OUT1);
	#endif

matixan avatar Apr 09 '24 13:04 matixan

Bump

matixan avatar Apr 22 '24 19:04 matixan

Why not write a PR?

CommentedNewline avatar Jun 28 '24 02:06 CommentedNewline

I've updated the file. Thank you very much

marcel-licence avatar Sep 01 '24 11:09 marcel-licence