Marc Bria

Results 144 comments of Marc Bria

Hummm... too much changes and build failed: https://gitlab.com/pkp-org/docker/ojs/-/jobs/3744339913 Will need to review it in detail. I will advice you as soon as the image is ready for testing.

Ok... there was an issue when running "node run build". Fixed now. Testing and pushing to dockerHub. Please, let me know if you find any issue.

In short: 1) fork lucas repo. 2) "git clone" your forked repo to your local computer. 3) Make your chages. 4) "git commit" to your local repo. 5) "git push"...

> i think you're confusing the docker image with de compose file, You are right. I was mixing both. I'm talking about the compose, but the thoughts are still valid....

You convinced me. And at the end, the default value can be easily overwritten in .ENV :-) About the demo scenario do you want me to ask for the demo...

> if you could ask that it would be great Ok. Let's keep this issue open to remember. > i'm just testing PWD and now it seems to work What...

> https://labs.play-with-docker.com/?stack=https://raw.githubusercontent.com/lucasdiedrich/ojs/test/docker-compose.yml It didn't works in my side with firefox and chrome. Containers are build but when I visit the url (even clicking in the link) I see a white...

Hi @sergiu017 Sorry for the delay in my answer. Not much time right now to follow the issues of this project. TL;DR; This is one of the biggests issues I'm...

I used a "file-volume" in past to make index.php persistent and overwrite some variables, but now that OJS is able to read X-Forward headers, is not required any more. Adding...

Thanks a lot for the feedback @sergiu017 In past I also overwrite PKPRequest to force https but then I noticed it's not the only place where the url is built......