node-html-pdf icon indicating copy to clipboard operation
node-html-pdf copied to clipboard

use phantomJS paperSize margin property in place of border

Open TomCoded opened this issue 6 years ago • 1 comments

margin replaced border six years ago in phantomJS, although backward compatibility still allows the border property to function correctly.

This change updates html-pdf to use the margin property and to continue recognizing the border property for backward compatitiblity.

fixes: https://github.com/marcbachmann/node-html-pdf/issues/403 refs: https://github.com/ariya/phantomjs/commit/a638a0733992730f3bd6e2ea3d11b4ec960f51fb

TomCoded avatar Mar 19 '18 08:03 TomCoded

@marcbachmann could this merged please?

michalzan avatar Dec 23 '21 23:12 michalzan