Marco Pasqualetti

Results 29 comments of Marco Pasqualetti

`upstream` remote is `i18next` `context-fix` is your repository

I'm trying on another machine

On M2 Max there is no performance issue...

After you added [` improve readability of typing`](https://github.com/i18next/i18next/pull/2182/commits/f82a259d69181c34b7e1de16c30df170a9c45b8f) commit the performance issue is no longer present

> I'm not sure I see how moving the code around a bit would make such a difference Actually it does: you moved the `context` validation from the `ActualOptions` type...

I personally don't have any problem changing the code to provide only valid context value, so [support falsy values](https://github.com/i18next/i18next/pull/2182/commits/c2ba23abacf2b0096ef1339d2b4b3591d55e5dd8) commit can be reverted also since your last comment: > Btw...

> So @marcalexiei and @stefan-schweiger should we merge this PR and release a new version? (patch/minor/major)? My main concern that is holding me back from approval is that now the...

Added a new test for https://github.com/i18next/i18next/pull/2182#pullrequestreview-2055968571 ("Default context value" section) via #2192

Could you please provide more information about this issue? E.g. Browser / code example