marcadella

Results 38 comments of marcadella

@stineb New initialization error: in gpp_biomee/gpp: `par_memory(layer)` is undefined when `layer` increases from 1 to 2. Should I initialize it with `par`?

Is it safe to assume that `par >= 0`?

I found the reason for why multiple consecutive runs yield slightly different outputs. In a lot of places in the code, some 'memory' variables are used. These variables persist until...

@stineb should `myinterface%steering%init` be used for forcing a reset of `init` in `biosphere_annual` (as it is done with `init_daily` for instance)?

I pushed a fix which seems to solve the issue using the solution described above. @stineb and could you double check commit `1407503f`?

Anything new on this?

This PR looks a bit dead @stineb . Should I cherry pick your changes into master and close it?

Up to you. I found it enough to use the mean to detect when I was breaking something. I was also always visualizing some plots. On Thu, Feb 27, 2025,...

Integration tests are definitely a must. Ideally, every Fortran routine should be tested, in addition to more general simulation output checks. After having see the extent of the code, I...