Marc Glasser

[$250] Add support for viewing full screen Group Chat custom avatars

58

## Problem When we added support for custom Group Chat avatars there are some places left where we cannot yet view the full screen avatar. ## Solution Navigate to the...

Coming from https://github.com/Expensify/App/pull/39757#issuecomment-2052653886 **Reproduction:** 1. Create a Group Chat 2. Navigate to report details page 3. Upload a custom avatar that is too large **Expected:** The error message displayed is...

Group Chat custom avatar not saved when navigating back to invite members page

1

Coming from https://github.com/Expensify/App/pull/39757#issuecomment-2052659550 1. Create a new group chat 2. Choose a picture for custom avatar 3. Go back to member invite page 4. Proceed again 5. Create chat **Expected:**...

We use a very popular checklist in the `Expensify/App` repo that asks authors and reviewers to consider and perform some sane checks on testing, code quality, best practices, etc. In...

Investigate flushing Onyx cache to disk on idle

23

We have observed that IndexedDB can be super slow with writes and cause major lag and jank in the app when there is a huge amount of data to store...

**Reproduction:** 1. Set something to Onyx in web implementation that cannot be serialized like `FormData` or some other class 2. See this: 

Local development is a bit painful after switching to a built JS bundle on dev

4

**Problem:** On dev we are pointing to `dist/web.development.js` which is a bit more difficult to test code changes. My current workaround is: Run `npm run build` in `/react-native-onyx` Copy `web.developent.js`...

`captureMetrics` doe not seem to be working anymore.

3

**Reproduction:** - Add `captureMetrics: true` in `Onyx.init()` - Observe error in JS console ``` app-c63af0784ac898b80ef3.bundle.js:33823 Uncaught TypeError: getAllKeys is not a function at addAllSafeEvictionKeysToRecentlyAccessedList (web.development.js?d0e7:698:1) at Object.init (web.development.js?d0e7:1418:1) at __WEBPACK_DEFAULT_EXPORT__...

# Problem - Subscribing to keys in non React component requires a bit of boilerplate code e.g. take these examples in the `libs/actions/Report.js` file ```js let currentUserEmail; let currentUserAccountID; Onyx.connect({...

cc @neil-marcellini and coming from https://github.com/Expensify/react-native-onyx/pull/129#discussion_r883005645... Unsure if there is any observable problem with this at the moment, but it just doesn't seem like the expected behavior. This is how...