Marc Glasser

Results 210 comments of Marc Glasser

I'm gonna close this one in favor of https://github.com/Expensify/Expensify/issues/384761 That lays out in clearer terms how this feature should work.

>I think that's exactly what happens when E.cash starts - a lot of operations at once I'm having trouble following some of this as it's a bit over my head....

>just using multiGet instead of get is enough to batch ~30 keys right at the start of the app >Then as the app continues to load 2-3 keys are fetched...

>Since I already have the change in git history, I can put it in a separate branch to test again after improvements in E.cash Sounds good. Let's put this on...

Gonna take this back off hold now so we can keep discussing this... >I think that's exactly what happens when E.cash starts - a lot of operations at once @kidroca...

I think we should create a new issue if it's OK. I have some thoughts and would like to reply, but feels like a different problem to the problem of...

>I'm surprised why that's not used internally for getItem as well This is a good question. I'd be curious to hear what the maintainers think. >We're still registering a separate...

FWIW, just swapping out `getItem` for `multiGet` with no other changes will batch a large number of keys during init. I logged this from `flushGetRequests` while starting up the Android...

Thanks! Looks cool! I'll give it a spin tomorrow. >Update STHROW to automatically log a debug stack trace to make it easier to debug Auth I think this is great....