Marc Alexander
Marc Alexander
Rebased the changes onto 3.3.x and created a follow up PR for master as well: #6457 #6458 Closing this PR in favor of those.
Closing in favor of #6500
Dicussions should continue in #6518
@phpbb/development-team PR can now be reviewed :)
VAPID keys can now be created in the ACP by clicking a separate button (the explain part of this setting still needs updating):  The JS code uses subtle crypto:...
> After some more testing ACP error log records have been noticed which look like: > > ``` > Web Push message could not be sent: Client error: `POST https://fcm.googleapis.com/fcm/send/fEqTxyze5jA:APA91bGamtwzxIFCAkL4WbzS2pZ_iEaG1VvaWiTqvY_VJqMg0NxbxOfqsLrKSiowd3aaLzoBh5l6b3es0_tbSAfTgKQv3GjsrRZzZP4ooYWJF3CdJ3ZM7tI-otzcKfWq2MM_BCv1Ijal`...
According to the documentation at https://web.dev/articles/push-notifications-web-push-protocol#response_from_push_service it should however be removed, there doesn't seem to be a refresh token system:410Gone. The subscription is no longer valid and should be removed...
@rxu I have now added handling that will remove subscriptions that have expired.
@rxu Yes, we could have a look at that. I'd however aim at first having the base functionality added and then we can continue with adding more features. :)
As noted on discord, the PR might result in BC breaks for some and adds quite a bit of changes to behavior and introduces new functionality so this shouldn't aim...