Marc Alexander

Results 43 comments of Marc Alexander

@lionel-rowe Hi, I was wondering if you could have a look at my comments. Would love to get this PR going again. Any help needed from our side to support...

Would we have to run this command every time we merge 3.2.x into master after this?

Seems like there is a conflict again :(

So just to clear up a simple question: Why are you leaving the old files with redirects to app.php? At least for viewtopic etc. this might make some sense although...

BTW, what's the point of having the legacy_front files? edit: Ah, nervermind. I guess those are the files that will be returned by accessing pages through app.php?

First notifications locally working with Google Chrome on Linux: ![image](https://user-images.githubusercontent.com/394418/195185974-2c1b3833-7c26-4a30-9e74-6ac3b478c728.png)

No, not like that. I meant card when I said card. I'll try to mock up something when I'm back home. The card is supposed to show not the same...

Closing in favor of https://github.com/phpbb/phpbb/pull/6599

Trying to create a search index for a non-supported type results in this message: ![image](https://user-images.githubusercontent.com/394418/206898325-f01efd3a-2a1e-43a6-bd2b-0ffc2db51e77.png) In the ACP the error message is clearer: ![image](https://user-images.githubusercontent.com/394418/206898341-fd41b215-0031-4e3a-b644-2c2b97e714a5.png) It also leaves the indexing in...

I've played around a bit with this but it really seems like tests don't want to work on 3.3.x. Will just close this PR as it's already working on master.