Marc Alexander

Results 43 comments of Marc Alexander

Looking at the PR, folders were partially removed. Is this supposed to be removed entirely?

Closed and reopened to force GitHub to run the tests again. Couldn't restart them directly. 🤷

If I read this correctly, the cleaner approach would probably be to completely remove the tabindex? In that case I'd actually then opt for removing it instead of setting it...

Thanks for your PR. I've taken the liberty of picking your first commit, cleaning up all the other commits, and fixing the commit message.

Btw, this currently does not properly upload images. Yes, seems like I broke it. :)

> can you post some screenshots of the rendered elements so I can work on new front-ends for them for chameleon and part backport it here? ![image](https://user-images.githubusercontent.com/394418/130502198-faee0266-c612-4f35-bc16-bec940c00562.png)

@hanakin should be ready for review again

@rubencm sorry but I seen to have missed it when you updated the PR. can you rebase it again to resolve the merge conflicts? thanks.

@lionel-rowe have you had time to look at my comments?