Marat Al

Understand and refactor "test__081__Channel__publish__Connection_state_conditions__the_message__should_NOT_be_queued_..._ATTACHED"

1

The test "test__081__Channel__publish__Connection_state_conditions__the_message__should_NOT_be_queued_instead_it_should_be_published_if_the_channel_is__ATTACHED" fails on the CI under macOS 13 [Beta] for several reasons: in case of `ttl`

Violation of the RTN24 and RTC8a1 specs

1

[RTN24](https://sdk.ably.com/builds/ably/specification/main/features/#RTN24) [RTC8a1](https://sdk.ably.com/builds/ably/specification/main/features/#RTC8a1) Library should pick up all `connectionDetails` in the `CONNECTED` protocol message to override any stored details. This seems not to be the case on connection [`UPDATE`](https://github.com/ably/ably-cocoa/blob/bdf38aed6e9a57bd5a5144ba8145ed06d0f00499/Source/ARTRealtime.m#L904C31-L904C31). ┆Issue is...

Violation of the RTN4h spec

1

[RTN4h](https://sdk.ably.com/builds/ably/specification/main/features/#RTN4h) >It emits an UPDATE ConnectionEvent for changes to connection conditions for which the ConnectionState (e.g. CONNECTED) does not change. (The library must never emit a ConnectionState ConnectionEvent for a...

Create a new test for `RTL2f` spec

1

Current test for `RTL2f` doesn't test what the spec implies (and was [removed](https://github.com/ably/ably-cocoa/pull/1791/commits/1a5f933f4068398009cf0641bfdfb76844fa5baa)): >A test should exist to ensure that resumed is always false when a channel first becomes ATTACHED,...

Revisit `RTL3d` tests.

1

I think both the purpose and the name of this test are slightly misleading. It claims it tests `RTL3d`, but instead addresses a bug in its behavior. I didn't find...

I was suggesting to add spec id like

1

I was suggesting to add spec id like https://github.com/ably/ably-go/blob/aea1a51ea5e67653453304778ff3f26f93cfff90/ably/options.go#L42 ``` SuspendedRetryTimeout: 30 * time.Second, // RTN14d, TO3l2 ``` You can see `// RTN14d, TO3l2` is added as a spec comment...

Refactor `onConnected:` not to use metadata.

1

I feel right place to use for code ``` self.options.recover = nil; // RTN16k [self resendPendingMessagesWithResumed:stateChange.resumed]; ``` is where resume is detected. Though I agree metadata is available, we don't...

Unskipped presence tests have FLAKY label for the quick identification in CI failures. Remove later if those tests don't fail. ┆Issue is synchronized with this [Jira Task](https://ably.atlassian.net/browse/ECO-4683) by [Unito](https://www.unito.io)

Extra call to `UIApplication.registerForRemoteNotifications`

1

The call to `UIApplication.registerForRemoteNotifications` is now managed inside `ably-cocoa` hence should be removed in the `AblyFlutterPlugin.m`. Link to PR - https://github.com/ably/ably-cocoa/pull/1293 ┆Issue is synchronized with this [Jira Task](https://ably.atlassian.net/browse/ECO-4606) by [Unito](https://www.unito.io)

Simplify the displaying of errors in the AblyPushExample

4

Now it shows alerts, but it makes the code very bulky. Should be something else, a text filed for example at the bottom of the window. ┆Issue is synchronized with...