Manoel Aranda Neto

Results 1021 comments of Manoel Aranda Neto

i think the user has to tell when the activity is ready to be used (vs fully drawn etc) maybe we could inspire or use https://developer.android.com/reference/kotlin/androidx/activity/FullyDrawnReporter#reportFullyDrawn()

https://github.com/square/papa/tree/main also has a few things related to what we do here but its more about the app's launch and not per activity i think (worth checking)

This could affect pricing so let's think before doing this change. An option is to make it configurable and keep it 24h by default.

Relates to https://github.com/PostHog/posthog-android/issues/189

probably would need something similar to https://github.com/getsentry/sentry-java/blob/main/sentry-kotlin-extensions/src/main/java/io/sentry/kotlin/SentryContext.kt so you can copy-pass the context across coroutines docs https://docs.sentry.io/platforms/java/enriching-events/scopes/#kotlin-coroutines

@Yadavanurag13, there are still some open comments, and CI is broken. Do you intend to come back to it?

> * https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches https://github.com/open-telemetry/opentelemetry-android/pull/663#discussion_r1941464425 left and ready to go, I will approve meanwhile.

@Victorsesan, let us know if you could fix CI/rebase as well. Otherwise, @bidetofevil will 'hijack' in good faith and get it mergeable.

@ioannisj can you review it? Also, I'd debug https://github.com/PostHog/posthog-ios/issues/344 first since its a different endpoint now (and likely easier to reproduce if there's a bug)

similar to https://github.com/PostHog/posthog-android/pull/245#issuecomment-2893824253 but here https://github.com/PostHog/posthog-ios/blob/479ce5ba9ce899dfe969dea7c88cd110adb800e7/PostHog/PostHogRemoteConfig.swift#L187C18-L187C35 and probably more places, @ioannisj would know more