maramihali issues

Results 73 issues of


                                            maramihali

Generalise computation of vanishing polynomial at challenge and lagrange basis and use batch_invert for computing denominators in K

ivc accumulate + decider verify fails when using the `MockCircuits` full circuits

bug

optimise memory usage in perturbator computation

optimization

serialise/deserialise transcript not working for folding/decider

The structure of the proof defined in `Ultra`/ `GoblinUltra` is different from what ProtoGalaxy is actually doing

`*RecursiveVerifier.verify_proof` should receive `StdlibProof` rather than `HonkProof` as argument

We are currently constructing a StdlibProof from a HonkProof inside the recursive verifiers which is an insecure pattern. Moreover, not hashing the verification key leads to potential weak Fiat-Shamir issues.

Establish whether the concept of mini_circuit_size is needed and cleanup pattern

cleanup

Refine access specifiers of flavor members

cleanup

valid `batch_mul` in a vanilla ultra circuit will fail when the group elements are equal

In the folding recursive verifier we might hit the scenerio where we do a `batch_mul(commitments, lagranges)` where the commitments are equal. That is because when we add gates to ensure...

bug

Recursive verification for TranslatorRecursiveVerifier::verifiy_translation()

Proper testing for translator

We are missing tests that ensure the translator fails when it should fail, proper translator transcript tests and failing tests for the translator recursive verifier due to the fact that...