FileUpload icon indicating copy to clipboard operation
FileUpload copied to clipboard

Consider replacing custom styles with bootstrap

Open maraf opened this issue 6 years ago • 22 comments

maraf avatar Feb 03 '19 10:02 maraf

Hello @maraf,

Do you require assistance with this? I can add a basic bootstrap 4 vanilla theme to FileUpload.

ghost avatar Feb 04 '19 13:02 ghost

@nicotravassos What do mean by vanilla theme? If it's some additional theme to bootstrap, can you provide a link with preview?

maraf avatar Feb 04 '19 16:02 maraf

🙈 😆 Ignore the vanilla part, all I meant was plain or basic clean theme.

ghost avatar Feb 04 '19 17:02 ghost

Ok them, if your are interested in another PR, I would like it.

It may be a bit of work here, because there is the need to rewrite current UI to be compatible with the bootstrap.

maraf avatar Feb 04 '19 19:02 maraf

Thanks @maraf, this should not take me long.

ghost avatar Feb 04 '19 19:02 ghost

Are you familiar with the LibMan? I would like you to use it for installation of bootstrap.

maraf avatar Feb 04 '19 19:02 maraf

Yap @maraf, will be using LibMan.

ghost avatar Feb 04 '19 19:02 ghost

Hello @maraf,

Work in progress simple and clean.

b1

ghost avatar Feb 05 '19 12:02 ghost

Looks good @nicotravassos! Just few thoughts,

  • I would like profiles to remain horizontal, right of File Manager header.
  • I like the svg image with file icons.
  • What is the right-bottom box?
  • And how it looks on mobile?

maraf avatar Feb 05 '19 16:02 maraf

@nicotravassos The modified at column has really sorting buttons?

maraf avatar Feb 05 '19 16:02 maraf

Thanks @maraf,

  • I would like profiles to remain horizontal, right of File Manager header.

I will change this to remain horizontal, right of File Manager header just thought if a user was going to add 20 profiles its going to start looking horrible.

  • I like the svg image with file icons.

SVG is back where it was 👍 .

  • What is the right-bottom box?

The right bottom box is filter where one can filter between modified dates and search file by name would you like me to remove it.

  • And how it looks on mobile?

No issues with mobile will show you screen shot when implementation is done.

The modified at column has really sorting buttons?

Yes it does, would you like me to remove it?

ghost avatar Feb 05 '19 17:02 ghost

I will change this to remain horizontal, right of File Manager header just thought if a user was going to add 20 profiles its going to start looking horrible.

There could be some breakpoint in the future "count(profiles) < 20 than 'horizontal' else 'vertical on the left'", but I would not bother with it right now.

The right bottom box is filter where one can filter between modified dates and search file by name would you like me to remove it.

I'm not sure. Filter is useful, but I would like a bit more minimalistic. I saw some table-header integrated filtering plugins for bootstrap. Something like than would be cool.

Yes it does, would you like me to remove it?

It's awesome! I wanted to implement it in #25. Is there a way to persist it in a cookie? So that after page reload, the ordering will remain. When we store it in a cookie, server-side rendering could also read it. If it's not so easy, leave it for separate issue #25.

Thanks a lot for the job you have already done!

maraf avatar Feb 05 '19 17:02 maraf

When we store it in a cookie, server-side rendering could also read it. If it's not so easy, leave it for separate issue

Will look into this tomorrow sounds simple.

ghost avatar Feb 05 '19 20:02 ghost

Hello @maraf,

I will commit my code on Sunday need to focus on another project this week.

ghost avatar Feb 06 '19 15:02 ghost

@nicotravassos no problem.

maraf avatar Feb 06 '19 16:02 maraf

Hi @nicotravassos. It's been a while. Are you coming back to this or do you have another work to be done? Let me know, please.

maraf avatar Mar 07 '19 18:03 maraf

I'm going to postpone this one...

maraf avatar Mar 08 '19 09:03 maraf

Hi @maraf,

I do apologize for the delay on this. I have been working on another clients website and have been focused on my studies so this project has slipped my mind. Please allow me to commit something during next week latest Wednesday, 13th of March.

ghost avatar Mar 09 '19 02:03 ghost

No problem @nicotravassos. When you have something ready, feel free to submit a PR.

maraf avatar Mar 09 '19 06:03 maraf

👍 Cool

ghost avatar Mar 09 '19 07:03 ghost

Hi @maraf,

I am writing a similar project to this but more of an archiving mechanism but its written in php. The design is similar to this one and in bootstrap when I am done Il make you template to integrate please dont hold back on updates on this project continue with backend.

ghost avatar Mar 21 '19 15:03 ghost

Ok

maraf avatar Mar 21 '19 17:03 maraf