mara004

Results 316 comments of mara004

Thanks for the pointers. I wasn't aware of the `libpdfium-nojs` AUR yet. As for s390x (or other special architectures), at least we're able to build now, but I agree finding...

> `update.py`: Consider passing `--format=json` to `gh at verify`. Run it only on one artifact, and check the others by hashes in the JSON output. Assert against more fields. done...

> Avoid potentially bloating `sys.path` in imports boilerplate. Might need to check `if ... not in sys.path` first? (Prio: Medium) done in daf5ec9, a4caaf5, 5a85f3e but I'm not entirely sure...

Hmm, I realized I'm not happy about how `gh attestation verify` is integrated. I don't like the bloated workaround code, and its use in workflows is particularly unfortunate as we...

Also logging the build script enhancement task here, as outlined on https://github.com/IBM/actionspz/issues/37#issuecomment-3475082434

More possible enhancements: - `build_native.py`: Add ability to vendor all dependency libraries. In particular, when building with non-system clang (e.g. https://github.com/mayeut/static-clang-images), it might be desirable to use the vendored libc++....

Some (much?) of the above has now been implemented/addressed. Extending `minitest.py` to at least render something would also be great. We can't run the test suite on all platforms because...

Other development will also continue here, to avoid time-taking rebases.

I'm guessing we should extract the non-split related changes and commit them to main first, after all...

> I'm guessing we should extract the non-split related changes and commit them to main first, after all... Done, see https://github.com/pypdfium2-team/pypdfium2/commit/b4f2bc6ecf39c65d6b27782919e0d0ee12af5ab8