wunderbaum icon indicating copy to clipboard operation
wunderbaum copied to clipboard

rowHeightPx is ignored

Open creffect opened this issue 1 year ago • 2 comments

Describe the bug The option "rowHeightPx" is ignored. It seems, that ROW_HEIGHT in the source code is always a constant and not changeable from 22px. (export const ROW_HEIGHT = 22 in common.ts)

To Reproduce Steps to reproduce the behavior: const tree = new Wunderbaum({ element: this.treeElement.nativeElement, source: [{title: "Test"}], rowHeightPx: 40 }); Expected behavior Row height is adjustable (for usability reasons).

Thank you for checking!

creffect avatar Feb 19 '24 21:02 creffect

Hello, to add to this: Would it also be possible to make the row height dynamic, e.g. depending on the row content?

Many thanks!

elevenlabsdev avatar Feb 28 '24 15:02 elevenlabsdev

Hello, to add to this: Would it also be possible to make the row height dynamic, e.g. depending on the row content?

Many thanks!

This would be way more complicated, since then we cannot define simple CSS rules for rows or calculate viewport sizes by simple multiplication. This should be discussed in a separate thread.

mar10 avatar Feb 29 '24 20:02 mar10

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 31 '24 14:05 github-actions[bot]