Maptz.VSCode.Extensions.CamelCaseNavigation icon indicating copy to clipboard operation
Maptz.VSCode.Extensions.CamelCaseNavigation copied to clipboard

NEEDS-DISCUSSION: Highlight code references on navigation

Open aghArdeshir opened this issue 4 years ago • 3 comments

HI! I already have filed an issue: https://github.com/maptz/Maptz.VSCode.Extensions.CamelCaseNavigation/issues/23

Now I came to add a workaround to it. My idea was to trigger a cursorLeft and cursorRight after each camelCase navigation. (So that cursor is at the right place, but also native vscode highlighting occurs).

Later I found that there is a specific command for this task: editor.action.wordHighlight.trigger

Unfortunately both this methods do not act exactly like vscode's native highlighting. There is a little sometimes annoying delay between highlights. In below GIF I demo both the native and this PR's highlihgting in action:

camel-case-navigation-demp

Now I doubt if this is good at all, or lack of this feature is better than having this version at all.

Another method that I think would be nice, is that this extension just calculates the amount of cursor moves that need to be applied, and then call cursorLeft and cursorRight corresponding multiple times. I try to see if I can work on that. (and also try to check if that does not cause performance issues)

aghArdeshir avatar Nov 21 '20 20:11 aghArdeshir

Hi @Ardeshir81 ,

Sorry for the delay getting to this.

How do you feel about this feature after a couple of months delay? Have you been using it?

maptz avatar Mar 25 '21 19:03 maptz

Hi @maptz . Its nice to know that you are Alive! :smiley:

I just re-checked it and the issue still is there. (Using VS-Code Insiders 1.55) I had a little problem with my PR back then, about the delay. I'll re-check it to see if it exists. I'll reach out to you.

Have a nice life :)

aghArdeshir avatar Mar 25 '21 22:03 aghArdeshir

Hey @maptz I just rechecked it. I still agree with this PR:

  • on branch master in main repository (this repository), navigating with ctrl + left_arrow and ctrl + right_arrow does not highlight variable usages
  • but on my branch it does
  • and I re-checked it in vscode-insiders 1.56.0

however:

  • still that lag/delay I told you about exists.
  • I have doubts about the diffs of the PR. two files named extension.js and extension.js.map in out folder have diffs in this PR. Are they supposed to be changed or should be auto-generated?
  • Tonight that I wanted to re-test my branch and I npm installed, two changes were made automatically by [email protected] and I committed them too.

I still believe merging this PR is a step forward, however is not best solution possible.

aghArdeshir avatar Apr 01 '21 19:04 aghArdeshir