tileserver-gl icon indicating copy to clipboard operation
tileserver-gl copied to clipboard

Published 20 hours ago • verified publisher icon maptiler

Added JWT support, updated a couple of dependencies

Open Sinnohd opened this issue 5 years ago • 1 comments

Hi,

I added support for JWT in the frontend (we use it with Lambda@Edge on AWS). I removed the legacy mapbox.js part and using now only mapbox-gl for both, vector and raster, tiles. Also updated quite a few dependencies (biggest change was the canvas upgrade, however on this one, I didn't found the time to test if the watermark feature is still fully functional).

Br, Jens

Sinnohd avatar Aug 01 '19 15:08 Sinnohd

Thanks for the PR!

However, it would be nice to have these a separate changes rather than 1 huge batch.

  • The JWT support seems to be pretty application-specific and I don't think it should be part of the tileserver-gl.

  • The mapbox.js is used for displaying raster tiles mainly for browsers without WebGL support (that's actually the main reason why tileserver-gl even bothers with the server-side rasterization) so replacing it with mapbox-gl kind of defeats the purpose

  • The canvas upgrade part is nice and I'd love to see this as a separate PR. Could you find time to create a clean canvas-upgrade-only PR for review?

petrsloup avatar Aug 12 '19 15:08 petrsloup