mapstruct-idea icon indicating copy to clipboard operation
mapstruct-idea copied to clipboard

add smart completion for ValueMapping

Open hduelme opened this issue 3 years ago • 2 comments

As discussed in #5 I add a smart filter to prevent already mapped source values from being displayed.

@filiphr could you have a look?

hduelme avatar Jun 22 '22 23:06 hduelme

Thanks for this PR @hduelme, can we please add some tests for this?

It would also be good not to use Impl classes such as PsiLiteralExpressionImpl, I think that there is PsiLiteralExpression.

filiphr avatar Jun 25 '22 20:06 filiphr

@filiphr I have replaced the usage of the Impl class by PsiLiteralExpression. I also added 2 tests:

  • one source value already mapped
  • all source values already mapped

hduelme avatar Jun 25 '22 21:06 hduelme

Thanks @hduelme. I've integrated this in https://github.com/mapstruct/mapstruct-idea/commit/2a80757c06ed6e7725dd140f6abe4e6eb058b414

filiphr avatar Nov 20 '22 11:11 filiphr