maproulette3 icon indicating copy to clipboard operation
maproulette3 copied to clipboard

add bundle resets on redirect

Open CollinBeczak opened this issue 1 year ago • 1 comments

Resolves: https://github.com/maproulette/maproulette3/issues/2222, https://github.com/maproulette/maproulette3/issues/1845 Backend: https://github.com/maproulette/maproulette-backend/pull/1107

Features included in this pr:

  1. The map will stay open when tasks are bundled.
  2. Bundle reset button for reviewers and mappers when they are working on a task that initially had a bundle.
  3. Other status's now visible on map. (This adds better context, and also allows allows the map to function as expected in the reviewer mode.

Bugs fixed: 1. Bug: Multiple people were able to work on the same tasks threw bundling. Solution: All tasks in the bundle will be locked when in task review or task completion settings. 2. Bug: New bundle created a bundle object that would never get deleted. Solution: New bundles will no longer persist when a user redirects away from a bundle, and will be broken back up into individual tasks. 3. Bug: When a reviewer edited a bundle, but did not submit the bundle, any changes they made were still saved. Solution: Bundles that are changed in review but are not submitted will be reset to their initial value if the reviewer redirects away.

New bundle. Bundle mode displaying only bundled tasks: Screenshot 2024-03-08 at 6 24 56 PM

Existing bundle. Bundle mode displayed but actions disabled: Screenshot 2024-03-08 at 6 26 08 PM

Existing bundle and reviewing. Bundle mode displayed but actions disabled: Screenshot 2024-03-08 at 6 25 27 PM

CollinBeczak avatar Mar 01 '24 23:03 CollinBeczak

Codecov Report

Attention: Patch coverage is 5.86207% with 273 lines in your changes are missing coverage. Please review.

Project coverage is 23.44%. Comparing base (6435413) to head (5e66ac9). Report is 13 commits behind head on main.

Files Patch % Lines
...c/components/HOCs/WithTaskBundle/WithTaskBundle.js 0.00% 53 Missing and 16 partials :warning:
...nents/Widgets/TaskBundleWidget/TaskBundleWidget.js 0.00% 40 Missing and 10 partials :warning:
...ents/Widgets/TaskBundleWidget/TaskMarkerContent.js 0.00% 28 Missing and 6 partials :warning:
.../components/TaskAnalysisTable/TaskAnalysisTable.js 9.67% 22 Missing and 6 partials :warning:
src/services/Task/Task.js 15.62% 22 Missing and 5 partials :warning:
...ChallengeTaskClusters/WithChallengeTaskClusters.js 0.00% 13 Missing and 4 partials :warning:
...ReviewNearbyTasksWidget/ReviewNearbyTasksWidget.js 0.00% 12 Missing and 3 partials :warning:
...s/WithTaskClusterMarkers/WithTaskClusterMarkers.js 0.00% 6 Missing and 2 partials :warning:
src/interactions/TaskCluster/AsMappableCluster.js 0.00% 6 Missing and 1 partial :warning:
...Map/LassoSelectionControl/LassoSelectionControl.js 50.00% 3 Missing and 1 partial :warning:
... and 8 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2291      +/-   ##
==========================================
- Coverage   23.59%   23.44%   -0.16%     
==========================================
  Files         648      648              
  Lines       22497    22653     +156     
  Branches     6944     7033      +89     
==========================================
+ Hits         5308     5310       +2     
- Misses      14366    14491     +125     
- Partials     2823     2852      +29     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 01 '24 23:03 codecov-commenter