electron-webrtc icon indicating copy to clipboard operation
electron-webrtc copied to clipboard

Published 20 hours ago • verified publisher icon mappum

Make it possible to use the promise-based API

Open getkey opened this issue 8 years ago • 6 comments

getkey avatar Jan 13 '17 15:01 getkey

Actually that doesn't work, sorry. I'm working on a fix.

getkey avatar Jan 13 '17 17:01 getkey

@mappum Thought on this PR?

It would be nice to support Promises since MDN says the callback API is deprecated.

getkey avatar Jan 25 '17 10:01 getkey

@getkey Sorry I missed this. Thanks for making this PR, keeping the API up-to-spec is important. I'll check this out/merge it later this week when I get time.

mappum avatar Jan 25 '17 19:01 mappum

Great, thanks!

getkey avatar Jan 25 '17 19:01 getkey

@mappum Hey, sorry to bug you again but have you had time to check it out? (and PR #92, too)

getkey avatar Feb 07 '17 18:02 getkey

I published the NPM package electron-webrtc-patched because I need the changes in this PR. I will take it down if my PRs are accepted.

getkey avatar Feb 26 '17 10:02 getkey