electron-eval icon indicating copy to clipboard operation
electron-eval copied to clipboard

Update `electron`

Open corbanvilla opened this issue 3 years ago • 0 comments

Description

The Electron version specified in package.json is 1.8.8. That version of Electron doesn't have any darwin-arm64 builds (any M1 mac).

Can we upgrade to atleast Electron 11? That's the most recent package to support arm builds.

Replicate Issue

  1. Initiate a new npm project (npm init -y)
  2. Install electron-eval with pnpm:
❯ npm i electron-eval
npm WARN deprecated [email protected]: This package is broken and no longer maintained. 'mkdirp' itself supports promises now, please switch to that.
npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: Please upgrade to latest, formidable@v2 or formidable@v3! Check these notes: https://bit.ly/2ZEqIau
npm WARN deprecated [email protected]: This module has been superseded by the multiformats module
npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: This module has been superseded by the multiformats module
npm WARN deprecated [email protected]: This module has been superseded by the multiformats module
npm WARN deprecated [email protected]: This module has been superseded by the multiformats module
npm WARN deprecated [email protected]: This module has been superseded by the multiformats module
npm ERR! code 1
npm ERR! path /private/tmp/owl/node_modules/electron
npm ERR! command failed
npm ERR! command sh -c node install.js
Downloading electron-v1.8.8-darwin-arm64.zip
npm ERR! Error: GET https://github.com/electron/electron/releases/download/v1.8.8/electron-v1.8.8-darwin-arm64.zip returned 404
npm ERR! /private/tmp/owl/node_modules/electron/install.js:47
npm ERR!   throw err
npm ERR!   ^
npm ERR!
npm ERR! Error: Failed to find Electron v1.8.8 for darwin-arm64 at https://github.com/electron/electron/releases/download/v1.8.8/electron-v1.8.8-darwin-arm64.zip
npm ERR!     at Request.<anonymous> (/private/tmp/owl/node_modules/nugget/index.js:169:61)
npm ERR!     at Request.emit (node:events:527:28)
npm ERR!     at Request.onRequestResponse (/private/tmp/owl/node_modules/request/request.js:1059:10)
npm ERR!     at ClientRequest.emit (node:events:527:28)
npm ERR!     at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:631:27)
npm ERR!     at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
npm ERR!     at TLSSocket.socketOnData (node:_http_client:494:22)
npm ERR!     at TLSSocket.emit (node:events:527:28)
npm ERR!     at addChunk (node:internal/streams/readable:315:12)
npm ERR!     at readableAddChunk (node:internal/streams/readable:289:9)

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/animcogn/.npm/_logs/2022-07-27T16_18_25_596Z-debug-0.log

corbanvilla avatar Jul 27 '22 16:07 corbanvilla