sssom-py icon indicating copy to clipboard operation
sssom-py copied to clipboard

Add SSSOM rewire to rewire method

Open matentzn opened this issue 2 years ago • 6 comments

This PR introduces the possibility of rewiring an SSSOM table based on another SSSOM table. This is in scope for sssom-py because of the complex handing of SSSOM mapping set metadata.

matentzn avatar Aug 03 '23 13:08 matentzn

@ehartley would you be interested to take this on? I created the basic outline of the method (without testing anything of course).

This will solve the sssom- rewiring problem at least. We can think of a generic client later, but note that due to the possibly complex handling of prefix map and metadata it makes sense to have a solid solution here as well.

matentzn avatar Aug 03 '23 13:08 matentzn

@matentzn yes, I can take this on.

ehartley avatar Aug 03 '23 18:08 ehartley

Super!

matentzn avatar Aug 03 '23 19:08 matentzn

#426 is about fixing the reconciliation code, which also effectively includes the solution to this

cthoyt avatar Sep 19 '23 06:09 cthoyt

@cthoyt Amazing! Ok then. @ehartley hold off then on any further thinking in this direction, lets wait for Charlie to tell us what, if anything, will be needed on top of his insane work right now :) Thanks @cthoyt

matentzn avatar Sep 19 '23 09:09 matentzn

@ehartley I added the code that standardizes a MSDF based on recent updates. You can continue on here. I realize I may have misunderstood what was going on here before, so I highly suggest writing several clear, explicit examples as unit tests before starting any implementation.

cthoyt avatar Sep 27 '23 08:09 cthoyt