sssom-py
sssom-py copied to clipboard
mapping-commons
Add the ontoportal mapping model json converter
About
related https://github.com/agroportal/project-management/issues/265
How to use
python -m sssom convert basic.tsv -o basic-ontoportal.json -O ontoportal_json
@syphax-bouazzouni thank you for your contribution! This is great and eyeballing what you have done so far, it looks good. I will provide you with a more detailed review later, but in the meantime, we are in general very keen on the parsers, not as much the writers - the idea being that we can use SSSOM as a universal exchange format, and sssom-py enabling tools to access resources in different formats. Would you be able to provide us with parser and extension of the sssom parse method as well?
@syphax-bouazzouni , I just received a review request from you. I seemed to have asked a few questions in August (above) and have not received a response. Could you please kindly address them.
hello @hrshdhgd, I think I responded to them, can you recheck please
hello @hrshdhgd, I think I responded to them, can you recheck please
Really sorry I forgot to submit my reviews (https://github.com/community/community/discussions/10369)
hello @hrshdhgd, I think I responded to them, can you recheck please
Really sorry I forgot to submit my reviews (community/community#10369)
Not a problem! Thanks for the PR and the clarification.
I see that QC check fails but it is an easy fix:
Run
tox -e linttox -e flake8
in your command line and that should fix some errors and show errors that need addressing. This basically formats your code and applies flake8 rules.
I see that QC check fails but it is an easy fix:
Run
tox -e linttox -e flake8in your command line and that should fix some errors and show errors that need addressing. This basically formats your code and applies flake8 rules.
Hi, I did the linting and fixed one of my failing tests. All tests passed now (the 63 ones)