sssom-py icon indicating copy to clipboard operation
sssom-py copied to clipboard

Validate() should be run as part of write_table()

Open matentzn opened this issue 3 years ago • 1 comments

It will cause a lot of errors at first, but overall, it will lead to better mapping data. The suggestion is that whenever we call write_table(), the final part of all sssom generating CLI methods, we should run the validator to make sure we only ever output legal sssom.

matentzn avatar Jun 22 '22 19:06 matentzn

I suggest parameterizing and allowing overrides, it may be necessary to occasionally write something incorrect in order to repair it.

cmungall avatar Jun 22 '22 19:06 cmungall

Maybe this is not a good idea after all. Closing.

matentzn avatar Jul 24 '23 14:07 matentzn