sssom-py icon indicating copy to clipboard operation
sssom-py copied to clipboard

sssom.yaml has oddly specific prefixes

Open cmungall opened this issue 4 years ago • 4 comments

https://github.com/mapping-commons/sssom-py/blob/master/schema/sssom.yaml#L6-L14

I think the following can be removed:

  • neuronames
  • orphanet/ordo

cmungall avatar Sep 28 '21 21:09 cmungall

The reason I added them is because they are different then the defaults (supplied by bioregistry, @cthoyt).

Basically when transforming an ontology like uberon, I added prefixes there if a) I didn't like the prefix assigned by bioregisrty or b) the prefix URL didn't exist in bioregisrty.

How should this be managed?

matentzn avatar Sep 29 '21 10:09 matentzn

Interestingly when I was reading through the OpenTargets stuff, I realized the Bioregistry's Orphanet/ordo URI made no sense and actually updated it a few days ago in https://github.com/biopragmatics/bioregistry/commit/21906c3.

I see you're using neuroname but I neuronames is already available in the Bioregistry http://bioregistry.io/registry/neuronames. We could add a synonym annotation to neuronames, but I don't ever recall seeing it written that way before.

If something's missing from the Bioregistry I would highly suggest you make a new prefix request 🚀

For the rest where you want to override what is happening in the Bioregistry, I think this makes total sense. Yesterday I had a short discussion with Chris and implemented https://github.com/biopragmatics/bioregistry/pull/169, so we can explicitly annotate the mixed case prefix for oboInOwl in the new preferred_prefix field there.

cthoyt avatar Sep 29 '21 10:09 cthoyt

Some bioregistry tickets:

  • https://github.com/biopragmatics/bioregistry/issues/183
  • https://github.com/biopragmatics/bioregistry/issues/182
  • https://github.com/biopragmatics/bioregistry/issues/187

matentzn avatar Sep 29 '21 12:09 matentzn

I think the bioregistry updates in the bioregistry tickets should have made these two annotations from the original issue obsolete

cthoyt avatar Oct 26 '21 12:10 cthoyt