sssom-py
sssom-py copied to clipboard
Implement test pypi releases to test before proper releases
https://github.com/ontodev/gizmos/blob/master/.github/workflows/python-test-publish.yml
This is a nice idea that I've considered before, but in practice never actually felt like I would need to do.
I think writing an appropriate MANIFEST.in file would be a more sustainable fix
That was the first thing I tried after looking at this post. It didn't fix the issue. I naively assumed it was a python 2.* (looking at the tags) fix and moved on.
Hi guys, sorry to drop in the conversation, I just found this issue linked in another one that is about to be closed.
Please consider that issues with include_package_data = True might have been solved in the latest version of setuptools and
the docs in https://setuptools.pypa.io/en/latest/userguide/datafiles.html should be reliable now (otherwise please go ahead and create another issue).
The idea is that if you have a non-Python file inside the package directory in the sdist and set include_package_data = True the wheel should also include the file. But you need to make sure the file is present in the sdist in the first place (either via MANIFEST.in or a plugin such as setuptools-scm).
You can see a detailed investigation here: https://github.com/abravalheri/experiment-setuptools-package-data
Thank you @abravalheri! I think @hrshdhgd had already found some solution to this? Maybe review the current solution in light of this?
Thank you for dropping in @abravalheri ! I did use include_package_data = True as seen here in the setup.cfg file and everything along with the MANIFEST.in file works as expected.