sssom-py icon indicating copy to clipboard operation
sssom-py copied to clipboard

Implement test pypi releases to test before proper releases

Open matentzn opened this issue 4 years ago • 7 comments

https://github.com/ontodev/gizmos/blob/master/.github/workflows/python-test-publish.yml

matentzn avatar Aug 31 '21 14:08 matentzn

This is a nice idea that I've considered before, but in practice never actually felt like I would need to do.

cthoyt avatar Aug 31 '21 14:08 cthoyt

This GitHub post addresses the fix:

delete the line include_package_data = True

hrshdhgd avatar Nov 29 '21 16:11 hrshdhgd

I think writing an appropriate MANIFEST.in file would be a more sustainable fix

cthoyt avatar Nov 29 '21 16:11 cthoyt

That was the first thing I tried after looking at this post. It didn't fix the issue. I naively assumed it was a python 2.* (looking at the tags) fix and moved on.

hrshdhgd avatar Nov 29 '21 16:11 hrshdhgd

Hi guys, sorry to drop in the conversation, I just found this issue linked in another one that is about to be closed.

Please consider that issues with include_package_data = True might have been solved in the latest version of setuptools and the docs in https://setuptools.pypa.io/en/latest/userguide/datafiles.html should be reliable now (otherwise please go ahead and create another issue).

The idea is that if you have a non-Python file inside the package directory in the sdist and set include_package_data = True the wheel should also include the file. But you need to make sure the file is present in the sdist in the first place (either via MANIFEST.in or a plugin such as setuptools-scm).

You can see a detailed investigation here: https://github.com/abravalheri/experiment-setuptools-package-data

abravalheri avatar Jan 17 '22 16:01 abravalheri

Thank you @abravalheri! I think @hrshdhgd had already found some solution to this? Maybe review the current solution in light of this?

matentzn avatar Jan 17 '22 16:01 matentzn

Thank you for dropping in @abravalheri ! I did use include_package_data = True as seen here in the setup.cfg file and everything along with the MANIFEST.in file works as expected.

hrshdhgd avatar Jan 17 '22 16:01 hrshdhgd