mapnik
Rename ünicode_symbols.xml?
Can we use a different unicode symbol in this file name that doesn't cause the issue described in https://stackoverflow.com/questions/5581857/git-and-the-umlaut-problem-on-mac-os-x?
On a fresh clone, I see the following output from git status:
On branch master
Your branch is up-to-date with 'origin/master'.
Untracked files:
(use "git add <file>..." to include in what will be committed)
"test/data/\303\274nicode_symbols.xml"
Are we hoping to test the unicode character in the actual file name here, or just the content within the .xml? It seems if we aren't concerned about the file name itself, we should just remove the umlaut.
It seems if we aren't concerned about the file name itself, we should just remove the umlaut.
I think the original intention was to have both: in the file name and in the file itself. I think ~2 months ago we had a failing test due to unicode characters that also lead to solve another bug. Also, for non-US languages it might be quite common to start words (equals filenames) with unicode characters. I suggest to leave as is.
Keeping a unicode char in the filename is likely a good idea, but can we switch it to a character that can't be written multiple ways? This issue is specifically caused by "umlaut normalization" as described in the link in the original post.
Why not make use of git config --global core.precomposeunicode?
If you are going to exchange some files with me there might very likely be some of those ÜöÄßéâ
:smiling_imp:
I tried setting git config --global core.precomposeunicode to true and false to no effect.
Have you tried both variants? As described in the link in the original post.
Some commenters said they needed it like this:
git config --global core.precomposeunicode true
Others said they needed it like this:
git config --global core.precomposeunicode false
Maybe depended on combination of git and OSX version?
Alright, I had to grab a fresh clone, but
git config --global core.precomposeunicode false
seems to work for me.